Does fastify contain cors ?

[wuchuwei]

Does fastify contain cors
thx

[StarpTech]

Good question. We should definitely support this as a plugin. @delvedor WDYT.

[StarpTech]

We could take this as a roadmap.

[delvedor]

It is not supported in core, but it could be a perfect plugin!

[mcollina]

you can use the http://npm.im/cors module through our middleware support.

[StarpTech]

Example

const cors = require('cors')
fastify.use(cors())

@mcollina but we don't provide a way to attach specific middlewares to a route correct?

[mcollina]

@StarpTech it should be fastify.use(cors()).

[gj]

@mcollina but we don't provide a way to attach specific middlewares to a route correct?

This looks like it does the trick: https://github.com/fastify/middie#restrict-middleware-execution-to-a-certain-paths

[mcollina]

closing as it should be solved.

[zhaoyao91]

won't CORS be implemented as a plugin?

current cors solution fails to handle so-called preflight request cors problem. see

• https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/OPTIONS#Preflighted_requests_in_CORS
• https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Preflighted_requests

In preflight request situation, the client will first send an options request to the server and generally, we only define the urls and methods we care about and leave the cors details to the middleware or plugins. This will lead to the options request failing since it is not defined in your app.

I am not sure about the detail, but using express didn't expose such a problem.

[mcollina]

I think we should do a plugin for cors.

If you look at: https://github.com/expressjs/cors#enabling-cors-pre-flight, you can see how they define the options route for a request.

IMHO our plugin should define fastify.enableCors('*') (or a specific path) that goes and creates that options route.

Side note, the following might just work together with the cors widdleware:

fastify.route({
  method: 'OPTIONS'
  path: '*'
}, (request, reply) => { reply.send() })

@zhaoyao91 let me know if that works for you.

[OhIAmFine]

Thanks for your advices, we made it successfully. @mcollina @zhaoyao91

In our practice, when we send a preflighted request by XMLHttpRequest in client, it will first send an options request, so we make it successfully by using cors and fastify.options in our plugins .

 fastify.use(cors())
 fastify.options('*', (request, reply) => { reply.send() })

[delvedor]

I'm working on a plugin :)

[delvedor]

Closed in #1076 :)

[SarasArya]

Thanks for your advices, we made it successfully. @mcollina @zhaoyao91

In our practice, when we send a preflighted request by XMLHttpRequest in client, it will first send an options request, so we make it successfully by using cors and fastify.options in our plugins .

 fastify.use(cors())
 fastify.options('*', (request, reply) => { reply.send() })

But you have write it in every file if you are using prefix