Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use namespace merging for nodenext #4491

Closed
wants to merge 6 commits into from
Closed

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 2, 2023

@climba03003 Regarding namespace merging.

It doesnt work. I assume because of

If you have an import or an export at the root level of a TypeScript file then it creates a local scope within that file.

https://jorgedacostaza.gitbook.io/typescript-pt/project/modules

@fastify/typescript
Any suggestion to fix this to use namespace merging across files?

Checklist

@Uzlopak Uzlopak changed the title use namespace merging use namespace merging for nodenext Jan 2, 2023
@github-actions github-actions bot added the typescript TypeScript related label Jan 2, 2023
@Uzlopak Uzlopak mentioned this pull request Jan 2, 2023
4 tasks
Base automatically changed from nodenext to main January 3, 2023 15:57
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 3, 2023

@

@Uzlopak Uzlopak closed this Jan 3, 2023
@Uzlopak Uzlopak deleted the nodenext-namespace-merging branch December 26, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant