-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RouteShorthandOptions
to receive async hooks
#4859
Comments
Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests. |
For anyone who would like to works on this issue. |
Hi @mcollina assign this to me |
Please provide a PR. Reassigning this to you. |
I asked @webstrand on discord if he could help us. |
Maybe somebody can open a question on stackoverflow? Usually @jcalz also answers there really fast. |
Hopefully, this is not repetitive but I wanted to note something (feel free to delete/hide if not beneficial to issue efforts).
Even if we specify the return as a
And likewise, providing an additional argument will resolve the issue (not really because it is meant to be async) because it recognizes the three args as one that includes a Maybe this is indicative of a complicated issue; I am not an expert on typescript. |
Prerequisites
Issue
Currently,
RouteShorthandOptions
type doesn't allow passing async hooks:It should be something like that:
The text was updated successfully, but these errors were encountered: