ci is flaky

[Uzlopak]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the issue has not already been raised

Issue

CI is annoyingly flaky.

But somehow it is everytime some other place where it fails.

[Uzlopak]

https://github.com/fastify/fastify/actions/runs/5496464439/jobs/10016529451

# Subtest: test/serial/logger.1.test.js
...   
        # Subtest: file option
            1..6
            ok 1 - expect truthy value
            not ok 2 - ENOENT: no such file or directory, open '/tmp/sonic-boom-3492-204,605947142-0'
              ---
              errno: -2
              code: ENOENT
              syscall: open
              path: /tmp/sonic-boom-3492-204,605947142-0
              tapCaught: uncaughtException
              test: file option
              ...

Why it fails is not clear. In other runs it works without any issue.

We could write a touch equivalent to potentially avoid it again. Like createTempFile in logger.1.test.js changed to this:

function createTempFile () {
  const file = path.join(os.tmpdir(), `sonic-boom-${process.pid}-${process.hrtime().toString()}-${count++}`)

  try {
    fs.utimesSync(file, new Date(), new Date());
  } catch (e) {
      let fd = fs.openSync(file, 'a');
      fs.closeSync(fd);
  }

  function cleanup () {
    try {
      fs.unlinkSync(file)
    } catch { }
  }
  return { file, cleanup }
}

[Uzlopak]

In https://github.com/fastify/fastify/actions/runs/5495909672/jobs/10015589787 the same test fails:

        # Subtest: file option
            1..6
            ok 1 - expect truthy value
            ok 2 - should match pattern provided
            not ok 3 - timeout!
              ---
              signal: SIGTERM
              handles:
                - type: Server
                  events:
                    - request
                    - connection
                    - clientError
                  connectionKey: 6:::1:0
              expired: TAP
              stack: >
                emit
                (node_modules/.pnpm/signal-exit@3.0.7/node_modules/signal-exit/index.js:105:13)
              
                process.listener (node_modules/.pnpm/signal-exit@3.0.7/node_modules/signal-exit/index.js:123:9)
              
                process.emit (node_modules/.pnpm/source-map-support@0.5.21/node_modules/source-map-support/source-map-support.js:516:21)
              test: file option
              ...

[Uzlopak]

again
https://github.com/fastify/fastify/actions/runs/5500549397/jobs/10023532410

       # Subtest: file option
            1..6
            ok 1 - expect truthy value
            ok 2 - should match pattern provided
            not ok 3 - timeout!
              ---
              signal: SIGTERM
              handles:
                - type: Server
                  events:
                    - request
                    - connection
                    - clientError
                  connectionKey: 6:::1:0
              expired: TAP
              stack: >
                emit
                (node_modules/.pnpm/signal-exit@3.0.7/node_modules/signal-exit/index.js:105:13)
              
                process.listener (node_modules/.pnpm/signal-exit@3.0.7/node_modules/signal-exit/index.js:123:9)
              
                process.emit (node_modules/.pnpm/source-map-support@0.5.21/node_modules/source-map-support/source-map-support.js:516:21)
              test: file option

[metcoder95]

All of them are within pnpm, is there pnpm doing something extra while running or has problems with Node v20?

[mcollina]

There are still a few bugs in Node.js v20 to fix. I think #4841 would give us more stable runs.