Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use external application for approving and merging #15

Merged
merged 1 commit into from Mar 12, 2021
Merged

Conversation

simoneb
Copy link
Collaborator

@simoneb simoneb commented Mar 12, 2021

New implementation which uses the external app for merging: https://github.com/fastify/dependabot-merge-action-app

Also:

  • bundling of action to avoid having to commit node_modules (and removing that from git), as suggested in the docs
  • optional api-url action input to customize which API to hit (defaults to the hosted heroku app)
  • linting
  • use strict everywhere

Fixes #13

@simoneb simoneb changed the title WIP: Next feat: use external application for approving and merging Mar 12, 2021
@simoneb simoneb marked this pull request as ready for review March 12, 2021 12:54
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simoneb simoneb merged commit 0cfdac0 into main Mar 12, 2021
@simoneb simoneb deleted the next branch March 12, 2021 14:16
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
@bcomnes
Copy link

bcomnes commented Mar 15, 2021

Can you clarify usage of the 2.0.0 version?

I need to enable the integration in addition to implementing the action? Or do I remove the action and just turn on the integration?

@simoneb
Copy link
Collaborator Author

simoneb commented Mar 15, 2021

@bcomnes see updated docs. The usage is unchanged but you need to install the companion GitHub App or host your own version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GITHUB_TOKEN is readonly and can't be used to merge the PR
3 participants