Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflow not supported #179

Closed
2 tasks done
climba03003 opened this issue Apr 12, 2022 · 1 comment · Fixed by #182
Closed
2 tasks done

github workflow not supported #179

climba03003 opened this issue Apr 12, 2022 · 1 comment · Fixed by #182

Comments

@climba03003
Copy link
Member

climba03003 commented Apr 12, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the regression has not already been reported

Last working version

3.0.2

Stopped working in version

3.1.0

Node.js version

/

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

/

💥 Regression Report

I think it should fallback to title regex when no package.json is found on diff.
Of cuz, it should not allow to upgrade if the title do not match which is different then before.

Steps to Reproduce

fastify/fastify#3825

Expected Behavior

github workflow should be supported.

@simoneb
Copy link
Collaborator

simoneb commented Apr 12, 2022

good catch, caused by not having good enough code coverage which we're addressing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants