Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Generate dist automatically #62

Closed
zekth opened this issue Aug 8, 2021 · 2 comments
Closed

ci: Generate dist automatically #62

zekth opened this issue Aug 8, 2021 · 2 comments

Comments

@zekth
Copy link
Member

zekth commented Aug 8, 2021

馃殌 Feature Proposal

Using the {{ secrets.GITHUB_TOKEN }} in github actions we can commit directly in the PR or the master branch; that could be interesting to do automatically on PRs, therefore when merging into master the dist folder will be all the time up to date.

Motivation

Simplify the build and release process

@simoneb
Copy link
Collaborator

simoneb commented Aug 9, 2021

I don't like the idea of making changes to the repository in CI. There are husky hooks in the repo, contributors should make sure they are run. PR reviews will catch if the dist folder has not been generated.

@zekth
Copy link
Member Author

zekth commented Aug 9, 2021

Closing as we rely on husky to generate those on commits.

@zekth zekth closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants