Help! Memory not freeing when receiving multipart files when ERR_STREAM_PREMATURE_CLOSE

[Kuyumee]

💬 Memory not freeing when receiving multipart files when ERR_STREAM_PREMATURE_CLOSE

How can I make Fastify clear up memory when an error occurs during request.saveRequestFiles() specifically ERR_STREAM_PREMATURE_CLOSE?

I have tried below code but it still doesn't free up memory

  let files;

  try {
    files = await request.saveRequestFiles();
  } catch (e) {
    console.log("Error saving files", e);
    await request.cleanRequestFiles();
    reply.code(500).send("Internal Server Error");
    return;
  }

GitHub

The graph shows that it takes half a day for the uploaded data to be released from memory

Your Environment

• node version: v16.17.0
• fastify version: ^4.17.0
• os: Windows

[Eomm]

Could you try to force the GC?
https://stackoverflow.com/a/30654451/3309466

(usually, V8 will clean the memory when necessary - for this reason chrome uses so much RAM actually)

[climba03003]

@Eomm Would it be something related to my comment? Some resources is not cleanup properly, so it hold the reference of unconsumed stream.

fastify/fastify-multipart#436 (review)

[Eomm]

mmm it seems so 👍🏼
I missed that PR - we should give it priority a bit

[Kuyumee]

Could you try to force the GC? https://stackoverflow.com/a/30654451/3309466

(usually, V8 will clean the memory when necessary - for this reason chrome uses so much RAM actually)

Forcing GC doesn't seem to free the memory