Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split test.js into multiple files #120

Closed
mcollina opened this issue May 1, 2019 · 1 comment
Closed

Split test.js into multiple files #120

mcollina opened this issue May 1, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@mcollina
Copy link
Member

mcollina commented May 1, 2019

I think test.js is becoming very hard to maintain as there is a lot of duplicated code. I think we should split into multiple files and create some helpers to reduce code duplication as much as possible.
@mcollina mcollina added the good first issue Good for newcomers label May 1, 2019
@amer8 amer8 mentioned this issue May 26, 2019
Merged
@amer8
Copy link
Contributor

amer8 commented May 26, 2019

Tests splitted in #122

@Eomm Eomm closed this as completed May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @Eomm @amer8