Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to manage the authentication #3

Closed
3 tasks
Eomm opened this issue Mar 28, 2019 · 7 comments
Closed
3 tasks

How to manage the authentication #3

Eomm opened this issue Mar 28, 2019 · 7 comments

Comments

@Eomm
Copy link
Member

Eomm commented Mar 28, 2019

Check how to manage the authentication process. The problems to face are 3:

  • github auth to interact with repo
  • npm for the publishing of the module
  • a little thought to CI/CD - we don't want to close this door too soon

I used already the Github API but I used a token:

https://github.com/Eomm/next-node-bot/blob/b5dc70255d9bf5d97fac780224e9788a0b9fddf3/index.js#L13

But I know it is only for private usage.. for what I know now I should go deeper

@mcollina
Copy link
Member

The tool should work with zero setup on the repo side. We have 30+ repositories in this repo, and we should really avoid to configure them all.

@Eomm
Copy link
Member Author

Eomm commented Mar 29, 2019

Yes, sure!!

I was thinking that there are 3 auth we could use:

  • git client, using the spawn.. so we don't' have to manage anything
  • npm client, using the spawn.. so we don't' have to manage anything
  • Github API, we need to deal with it because there isn't a "build a release" command in the cli, but only a tag

In this way, it should be quite simple to do, but for sure we can't think on CI/CD because nobody installs git client on the CI server 😅

@mcollina
Copy link
Member

You don’t need to auth the git client, nor npm. You just need to auth github with a personal access token.

@mcollina
Copy link
Member

(auth for git and npm isngoing to be done by the user separately)

@Eomm Eomm mentioned this issue Apr 8, 2019
@Eomm
Copy link
Member Author

Eomm commented Apr 11, 2019

Does someone know if there is some "dev" environment to try the GitHub Rest API?

I have googled a bit but I don't find anything more than the test-env for GH APP

@mcollina
Copy link
Member

Yes there is! Create a personal repo!

@Eomm Eomm mentioned this issue Jun 13, 2019
@Eomm
Copy link
Member Author

Eomm commented Feb 18, 2020

Solved

@Eomm Eomm closed this as completed Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants