Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastlane-env-reminder false positives #10

Closed
janpio opened this issue Sep 21, 2019 · 4 comments
Closed

fastlane-env-reminder false positives #10

janpio opened this issue Sep 21, 2019 · 4 comments

Comments

@janpio
Copy link
Member

janpio commented Sep 21, 2019

List of issues that triggered the bot although env info was provided:

@janpio
Copy link
Member Author

janpio commented Sep 21, 2019

@mollyIV
Copy link
Member

mollyIV commented Sep 23, 2019

Hey @janpio,

The GitHub Action is triggered when an issue is created.

fastlane/fastlane#15353 (comment)

The issue description ☝️has been edited - can we confirm that fastlane env info was provided at time of issue creation? If the issue was created and then edited (provided fastlane env), the comment about providing missing env would be totally ok 👌

@janpio
Copy link
Member Author

janpio commented Sep 23, 2019

Ahh, good point! I will make it a feature request to maybe hide or delete the comment if the issue was edited and the information was added.

@mollyIV
Copy link
Member

mollyIV commented Sep 25, 2019

@janpio I had a look at the last 5 issues created on fastlane repository:

image

No false positives 🎉

Can we please close this issue? Thanks 🙇

@janpio janpio closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants