This repository has been archived by the owner on Nov 19, 2018. It is now read-only.
[Ready] Update for the new iTunes Connect #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fetching and updating of localised app data
| end | ||
|
|
||
| # Custom Setters | ||
| # |
| # "readyToInstall"=>true, | ||
| # "sdkBuildWhitelisted"=>true, | ||
| # "internalTesting"=>{"value"=>false, "isEditable"=>true, "isRequired"=>false, "errorKeys"=>nil}, | ||
| # "externalTesting"=>{"value"=>false, "isEditable"=>true, "isRequired"=>false, "errorKeys"=>nil} |
There was a problem hiding this comment.
Incorrect indentation detected (column 2 instead of 0).
| with(headers: {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'Cookie' => itc_cookie, 'User-Agent' => 'spaceship'}). | ||
| to_return(status: 200, body: itc_read_fixture_file('create_application_success.json'), headers: {'Content-Type' => 'application/json'}) | ||
|
|
||
|
|
|
|
||
| stub_request(:get, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/overview"). | ||
| with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Cookie'=>'myacinfo=DAWTKN;woinst=3363;itctx=abc:def;wosid=xBJMOVttbAQ1Cwlt8ktafw', 'User-Agent'=>'spaceship'}). | ||
| to_return(:status => 200, body: itc_read_fixture_file('app_overview.json'), headers: {'Content-Type' => 'application/json'}) |
There was a problem hiding this comment.
Unnecessary spacing detected.
Use the new Ruby 1.9 hash syntax.
Trailing whitespace detected.
| # App Details | ||
| stub_request(:get, "https://itunesconnect.apple.com/WebObjects/iTunesConnect.woa/ra/apps/898536088/details"). | ||
| with(:headers => {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Cookie'=>'myacinfo=DAWTKN;woinst=3363;itctx=abc:def;wosid=xBJMOVttbAQ1Cwlt8ktafw', 'User-Agent'=>'spaceship'}). | ||
| to_return(:status => 200, body: itc_read_fixture_file('app_details.json'), headers: {'Content-Type' => 'application/json'}) |
There was a problem hiding this comment.
Unnecessary spacing detected.
Use the new Ruby 1.9 hash syntax.
Trailing whitespace detected.
KrauseFx
added a commit
that referenced
this pull request
Sep 25, 2015
[WIP] Update for the new iTunes Connect
KrauseFx
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open tasks 馃殌
testing_statusof a build doesn't worktrain = app.build_trains["1.0"].builds.first.test_status