Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log output should be simplified when running in CI #175

Closed
kailan opened this issue Dec 3, 2020 · 2 comments · Fixed by #405
Closed

Log output should be simplified when running in CI #175

kailan opened this issue Dec 3, 2020 · 2 comments · Fixed by #405
Assignees
@phamann
Labels
bug Something isn't working

Comments

@kailan
Copy link
Member

kailan commented Dec 3, 2020

Example from GitHub Actions:

Screenshot 2020-12-03 at 10 47 53
@kailan kailan added the bug Something isn't working label Dec 3, 2020
@drwilco
Copy link

drwilco commented Dec 3, 2020

I would say don't use spinners/colors when not a terminal: https://rosettacode.org/wiki/Check_output_device_is_a_terminal#Go

@kailan
Copy link
Member Author

kailan commented Mar 5, 2021

This issue can be closed. For the sake of CI, the --verbose flag provides the right output.

@kailan kailan closed this as completed Mar 5, 2021
@phamann phamann reopened this Sep 15, 2021
@phamann phamann mentioned this issue Sep 15, 2021
Merged
@phamann phamann self-assigned this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phamann phamann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a non-interactive progress writer in non-TTY environments fastly/cli
3 participants
@phamann @drwilco @kailan