Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pull request template #161

Closed
gschorkopf opened this issue Apr 8, 2020 · 2 comments
Closed

Add a pull request template #161

gschorkopf opened this issue Apr 8, 2020 · 2 comments
Labels
good first issue

Comments

@gschorkopf
Copy link
Member

Adding a file in the path .github/PULL_REQUEST_TEMPLATE.md will allow us to have uniform pull requests. Some thoughts on what to put there:

  • What issue is this resolving?
  • Any particular things to focus on for review?
  • What kind of version bump (if any) does this require?
@annawinkler
Copy link
Contributor

I appreciate the addition of a feels giphy when people feel so inclined ✨

@Integralist
Copy link
Contributor

Closing this issue now we've published v4.0.0 https://rubygems.org/gems/fastly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Integralist @gschorkopf @annawinkler