Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins: console logging support improvements #434

Merged
merged 15 commits into from Mar 3, 2023
Merged

builtins: console logging support improvements #434

merged 15 commits into from Mar 3, 2023

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Mar 2, 2023 •
edited

Updates the console logging builtin with various improvements, specifically:

  • Array logging
  • Quoting strings
  • Object spacing
  • Functions and function names properly shown, but skipped if they are not own properties
  • Getter and Setter properties shown but not triggered, also skipped if not own properties
  • Class names are displayed for all objects with a constructor
  • TypedArrays log as arrays, along with the array type

@JakeChampion JakeChampion merged commit 7a74d76 into main Mar 3, 2023
@JakeChampion JakeChampion deleted the guybedford/object-logging branch March 3, 2023 04:47
@JakeChampion JakeChampion mentioned this pull request Mar 3, 2023
Merged
@guybedford guybedford mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guybedford @JakeChampion