feat: Add ability to disable connection-pooling behavior for Dynamic Backends #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
reviewed
Jul 10, 2023
JakeChampion
force-pushed
the
jake/dont-pool-option
branch
2 times, most recently
from
fc594fc
to
8363d51
Compare
You are right, yes -- that has now been updated 👍 |
elliottt
approved these changes
Jul 11, 2023
| backend_config_mask |= BACKEND_CONFIG_USE_SSL; | ||
| if (config->ssl_min_version.is_some) | ||
| } | ||
| if (config->dont_pool.is_some && config->dont_pool.val) { |
…Backends This commit adds a new `dontPool` optional property to the `Backend` constructor, which indicates whether or not to disable connection-pooling. Connection pooling is the ability to re-use connections across different executions/sessions of a Fastly Compute@Edge Service Fastly considers two backends "the same" if they’re registered with the same name and the exact same settings. In those cases, when connection pooling is enabled, if an execution/session opens a connection to a backend, the connection will be left open, and can be re-used by another execution/session. This pooling behaviour can help improve backend latency, by removing the need for the initial network / TLS handshake(s). By default, pooling is enabled for Dynamic Backends, but can be disabled when using the Explicit Dynamic Backend API.
JakeChampion
force-pushed
the
jake/dont-pool-option
branch
from
8363d51
to
50a26c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
dontPooloptional property to theBackendconstructor, which indicates whether or not to disable connection-pooling.Connection pooling is the ability to re-use connections across different executions/sessions of a Fastly Compute@Edge Service Fastly considers two backends "the same" if they’re registered with the same name and the exact same settings. In those cases, when connection pooling is enabled, if an execution/session opens a connection to a backend, the connection will be left open, and can be re-used by another execution/session. This pooling behaviour can help improve backend latency, by removing the need for the initial network / TLS handshake(s). By default, pooling is enabled for Dynamic Backends, but can be disabled when using the Explicit Dynamic Backend API.