fix: Allow URL as input on fetch() on TypeScript typings for compat with Node.js #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmony7
force-pushed
the
kats/fetch-input-type
branch
from
1421775
to
a55af54
Compare
JakeChampion
changed the title
JakeChampion
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
URLas an allowed type for the first parameter of thefetch()function in the TypeScript type definitions.The parameter is listed in MDN to be anything that is a string or has a stringier, including URL.
The functionality seems to already be there in the runtime.
Node.js's typings has RequestInfo | URL.
Currently if you write a program that happens to load both typings and there isn't a way around it, then if you pass a URL to the fetch() function, it will think you're calling Node.js's fetch and not ours, so this would be a usability fix.