This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Dynamic traits without "dyn" will not be supported any more #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add explicit lifetimes, because implicit ones is so 2015.
acfoltzer
suggested changes
Jun 21, 2019
There was a problem hiding this comment.
Can you add #![deny(bare_trait_objects)] to our crates so this will be enforced?
Also, do you know of a way we could enforce the rule for implicit lifetimes? I don't see one on the list of lints in https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html, but maybe clippy has one?
|
Done. Unfortunately, I don't know of a way to enforce the rule for implicit lifetimes. I was hoping that this requirement would eventually get reverted, but apparently not :( |
pchickey
approved these changes
Jun 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add explicit lifetimes, because implicit ones is so 2015.