Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache should be invalidated on fpack executable changes #16

Closed
andreypopp opened this issue Jan 14, 2018 · 3 comments
Closed

Cache should be invalidated on fpack executable changes #16

andreypopp opened this issue Jan 14, 2018 · 3 comments
Labels
bug

Comments

@andreypopp
Copy link
Collaborator

No description provided.

@andreypopp andreypopp added the bug label Jan 14, 2018
@andreypopp andreypopp changed the title Cache should be invalidated on fpack executable changes Cache should be invalidated on fpack executable changes Jan 15, 2018
@zindel
Copy link
Member

zindel commented Jan 15, 2018

We account on github commit ID in the cache filename. Should be good for releasing, when we update the Version.github_commit, although still doesn't solve the problem in development.

Changing the cache format into tuple / record leads to significant performance penalty.

@andreypopp
Copy link
Collaborator Author

Should this be closed?

@zindel
Copy link
Member

zindel commented Jan 29, 2018

Yep

@zindel zindel closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreypopp @zindel