Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modes for selector Sychronizer and use of arrow key #262

Closed
4 tasks
Tracked by #130
kushalkolar opened this issue Jun 27, 2023 · 3 comments
Closed
4 tasks
Tracked by #130

Modes for selector Sychronizer and use of arrow key #262

kushalkolar opened this issue Jun 27, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@kushalkolar
Copy link
Member

Right now the Synchronizer for selctors seems to work for pointer events.

  • make it work for arrow key events too, so that we can sync selectors between different renderers (and therefore different plot areas)
  • have two modes
    • one where it just sychronizes the deltas (this is how it is currently implemented) but Selectors can all be in different positions.
    • another mode where it sychronizes the absolute position of the selectors, this is useful for moving things in sync across different renders (i.e. different plot areas)
@clewis7
Copy link
Member

clewis7 commented Jun 27, 2023

I think this is a good idea and would have a lot of use cases (i.e. animal soup ethogram comparisons lol)

What would be the default though? Syncing with deltas or absolute position? I feel like the latter is more desirable and reflects "syncing" behavior better.

@kushalkolar kushalkolar added the good first issue Good for newcomers label Jul 15, 2023
@kushalkolar kushalkolar mentioned this issue Sep 21, 2023
17 tasks
@kushalkolar
Copy link
Member Author

put this on hold until pygfx/pygfx#665 and #413

@kushalkolar
Copy link
Member Author

synchronizer will be removed in #473 , so I'm closing this. This should be handled in higher level libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants