a few clang warning fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2014 12:19
…inor problems MotionBlurFilter - using floating point based abs instead of integer based - declare as static inline for function prototype declaration For the floating point conversion, we could add in a nearbyintf, if we want integer rounding
- floating point based methods instead of integer based abs (we could use nearbyintf if we want rounding) - opacity is a float, some systems CGFloat is a double - missing newline at bottom of file warning
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @fastred, great library! made a couple minor modifications so that it could compile in one of my projects.
i use a pretty strict environment, if you're curious, the configuration can be found here:
https://github.com/piemonte/xconfig