Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove velocity input for all functions. Only require Reynolds numbers and Prandtl number. #16

Open
lcarasik opened this issue Dec 3, 2017 · 2 comments
Assignees
Projects

Comments

@lcarasik
Copy link
Collaborator

lcarasik commented Dec 3, 2017

The current pressure drop function for GG includes the Reynolds number as an input. This should be directly calculated from the provided free stream velocity.

@lcarasik lcarasik self-assigned this Dec 3, 2017
@lcarasik lcarasik added this to To Do in Version 2.0 Dec 3, 2017
@lcarasik
Copy link
Collaborator Author

This should actually be done where Reynolds number and Prandtl number is an input to each function. The Reynolds number and others should be calculated in a wrapper for the user to use.

@lcarasik lcarasik changed the title Remove Reynolds dependence on the GG pressure drop function Remove velocity input for all functions. Only require Reynolds numbers and Prandtl number. Dec 30, 2017
@lcarasik lcarasik moved this from To Do to Working On in Version 2.0 Jan 6, 2019
@lcarasik
Copy link
Collaborator Author

lcarasik commented Jan 6, 2019

This will require the following:

  • Add function to calculate Reynolds number for both in-line and staggered geometries.
  • Update friction factor GG
  • Update friction factor Zu
  • Update Nusselt GG
  • Update Nusselt Zu
  • Updating the master_example.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 2.0
  
In Progress
Development

No branches or pull requests

1 participant