Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Project uses npm but Rails standard is yarn #108

Closed
arielj opened this issue Jul 26, 2021 · 1 comment · Fixed by #119
Closed

Project uses npm but Rails standard is yarn #108

arielj opened this issue Jul 26, 2021 · 1 comment · Fixed by #119
Labels
enhancement New feature or request

Comments

@arielj
Copy link
Contributor

arielj commented Jul 26, 2021

Branch/Commit:

Main branch

Expected behavior:

New Rails applications use yarn to handle node modules, we should use the same here for consistency.

Actual behavior:

The app uses npm to handle node modules. On CI it is running both npm install manually and then rails runs yarn install when compiling the assets.

Notes:

We should document how to install node modules using yarn and add a yarn.lock file to the repo instead of the package-lock.json file that is created by npm.

I will abide by the code of conduct

@arielj arielj changed the title [BUG] Project uses npm install but Rails [BUG] Project uses npm but Rails standard is yarn Jul 26, 2021
@bronzdoc bronzdoc changed the title [BUG] Project uses npm but Rails standard is yarn Project uses npm but Rails standard is yarn Aug 11, 2021
@bronzdoc bronzdoc added the enhancement New feature or request label Aug 11, 2021
@bronzdoc
Copy link
Contributor

I don't think this is a bug

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants