Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support spring #28

Open
timdiggins opened this issue Dec 13, 2021 · 2 comments
Open

support spring #28

timdiggins opened this issue Dec 13, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@timdiggins
Copy link

Thanks for the work on this fork/gem.

I think that currently commands like next rails c when you have "springified" your rails will cause errors, or will always invoke the previous rails rather than the current one. I think this is a matter of making the ENV var changes exported from the next.sh script in line 39

BUNDLE_GEMFILE=Gemfile.next BUNDLE_CACHE_PATH=vendor/cache.next bundle exec $@

ie. changing this to

    export BUNDLE_GEMFILE=Gemfile.next BUNDLE_CACHE_PATH=vendor/cache.next 
    bundle exec $@

This is quite a small change so it might be easier if a committer did it, but happy to contribute a PR.

@timdiggins
Copy link
Author

Actually I've just tested this out and my theory seems to be wrong. You need the export BUNDLE_GEMFILE=Gemfile.next in the calling shell (where you type next rails c or whatever) -- doing it within next.sh, doesn't fix the issue with spring.

It would still be good to support spring automatically (you still need to manually start and stop spring) but for now the workaround seems to be to export BUNDLE_GEMFILE=Gemfile.next rather than (or in addition to) using next

@kindoflew kindoflew added enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2021
@aisayo aisayo self-assigned this Jul 25, 2022
@fbuys
Copy link

fbuys commented Jun 15, 2023

I have seen a similar thing.

I have never tried to determine the steps to replicate this issue.
Does anyone have the steps to replicate it?

@etagwerker etagwerker removed the good first issue Good for newcomers label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants