Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SimpleCov > 0.18.x #40

Closed
3 tasks
etagwerker opened this issue Apr 28, 2020 · 1 comment · Fixed by #53
Closed
3 tasks

Add support for SimpleCov > 0.18.x #40

etagwerker opened this issue Apr 28, 2020 · 1 comment · Fixed by #53
Assignees
Labels
ROSS ROSSConf 2020

Comments

@etagwerker
Copy link
Member

etagwerker commented Apr 28, 2020

Right now skunk is not compatible with the latest release of SimpleCov -- more here: simplecov-ruby/simplecov#887

We should follow this path:

You will get unexpected results if you're trying to use a coverage/.resultset.json file generated with SimpleCov v0.18.x or higher.

@etagwerker etagwerker changed the title Add support for SimpleCov 9 Add support for SimpleCov > 0.18.x Apr 28, 2020
@bronzdoc bronzdoc self-assigned this Sep 29, 2020
@etagwerker
Copy link
Member Author

@bronzdoc Update: The latest release of RubyCritic is compatible with the most recent versions of SimpleCov. So this should be simple: We can relax this dependency: https://github.com/fastruby/skunk/blob/main/skunk.gemspec#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROSS ROSSConf 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants