Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting the PHP Code Base #13

Closed
ConradSollitt opened this issue Jan 24, 2020 · 1 comment
Closed

Linting the PHP Code Base #13

ConradSollitt opened this issue Jan 24, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ConradSollitt
Copy link
Contributor

Currently the PHP Code base is well tested but not fully linted. Minor updates are being made for validation with limiting tools. Almost all updates are related to PHPDoc Comments or false positive issues that need to be ignored.

This will be an on-going update over the next few weeks. Any help would be greatly appreciated. PHP experience is not needed since it's mostly code comments and validation. If you know JavaScript or another language that should be enough and this could be a good way for someone to become more familiar with PHP.

See notes near the top to-do-list file:
https://github.com/fastsitephp/fastsitephp/blob/master/docs/to-do-list.txt

PHP Linters (Static Analysis Tools) being tested
https://github.com/phpstan/phpstan
https://github.com/vimeo/psalm
https://github.com/phan/phan

@ConradSollitt ConradSollitt added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 24, 2020
@ConradSollitt
Copy link
Contributor Author

All Framework code is now linted so this issue will be closed out.

phpstan was chosen. For info on how to run see comments in:
https://github.com/fastsitephp/fastsitephp/blob/master/phpstan.neon

A previous config file for psalm is shown here however psalm will not be used so the file is being deleted from the master branch.
https://github.com/fastsitephp/fastsitephp/blob/ed87047e8b6199d0f8baf69362845674a0a28556/psalm.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant