Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open 2 threads for each Page object? #12

Closed
IanChen83 opened this issue Sep 29, 2017 · 1 comment
Closed

Open 2 threads for each Page object? #12

IanChen83 opened this issue Sep 29, 2017 · 1 comment

Comments

@IanChen83
Copy link

IanChen83 commented Sep 29, 2017

I think it's not efficient to have each page creating its own recv_loop thread and event_handler_loop thread. This mechanism should be implemented under Browser class, and even every tab is manipulated in its own thread, the order of returned responses still won't change.

Just checked out how GoogleChrome/puppeteer implements this. What do you think?
https://github.com/GoogleChrome/puppeteer/search?q=Connection

@fate0
Copy link
Owner

fate0 commented Sep 30, 2017

well, webSocketDebuggerUrl doesn't exists in Chrome 61 /json/version/ and doesn't show up in stdout. That means puppeteer does not support the Chrome61 or lower version. so I can't implement pychrome like puppeteer does.

@fate0 fate0 closed this as completed Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants