Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Stop the client or server gracefully #2670

Closed
5 of 11 tasks
hinupurthakur opened this issue Nov 22, 2021 · 4 comments · Fixed by #3511
Closed
5 of 11 tasks

[Feature Request] Stop the client or server gracefully #2670

hinupurthakur opened this issue Nov 22, 2021 · 4 comments · Fixed by #3511
Labels

Comments

@hinupurthakur
Copy link

hinupurthakur commented Nov 22, 2021

Describe the feature request

Currently we don't have a command that can stop the frp client (or server) gracefully on a machine

Describe alternatives you've considered

we should have a command like frpc stop (or frps stop) to stop the active connections gracefully.

Please let me know if this is something we would like to have as a feature, I can help to contribute as well.

Thanks

Affected area

  • Docs
  • Installation
  • Performance and Scalability
  • Security
  • User Experience
  • Test and Release
  • Developer Infrastructure
  • Client Plugin
  • Server Plugin
  • Extensions
  • Others
@fatedier
Copy link
Owner

I'm not sure if it's necessary.

Can you describe more about your use case and how to decide when frp service can stop?

Lots of people use frp as port forwarder and their connections will keep alive for a long time.

@hinupurthakur
Copy link
Author

@fatedier Thanks for the response. I am using it with the application for the http proxy. Once I close the application, I want the frpc to stop (not the server, in my case). Currently I am doing it by the process ID but if we can have an option like frpc stop but only if this use case is not too specific for my use.
Thank You!

@fatedier
Copy link
Owner

I think it's ok to support graceful shudown only on frpc.

We can add a new api like /api/stop and frpc stop --grace-period=10 will call this api.

PRs on this feature are welcome.

@fatedier fatedier added todo and removed proposal labels Nov 24, 2021
@hinupurthakur
Copy link
Author

If nobody have yet taken this issue up, I will be happy to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants