Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double plugin bug #3

Merged
merged 3 commits into from Apr 1, 2017
Merged

Fix double plugin bug #3

merged 3 commits into from Apr 1, 2017

Conversation

fatfisz
Copy link
Owner

@fatfisz fatfisz commented Apr 1, 2017

This fixes tleunen/babel-plugin-module-resolver#148.

The plugin was broken when it was included twice: the options in the second plugin were not being normalized. The RegExp feature and also the big refactor (#2) caused this bug to surface.

pre is a better place than manipulateOptions to handle default options, so normalization should be moved there.

@fatfisz fatfisz self-assigned this Apr 1, 2017
@codecov-io
Copy link

codecov-io commented Apr 1, 2017

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/getRealPath.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554fc97...d6ed2df. Read the comment docs.

@fatfisz fatfisz merged commit 944a002 into master Apr 1, 2017
@fatfisz fatfisz deleted the fix-double-plugin-bug branch April 1, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'find' of undefined
2 participants