Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not use tags for checkout #64

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix(build): do not use tags for checkout #64

merged 1 commit into from
Feb 6, 2023

Conversation

licy183
Copy link
Contributor

@licy183 licy183 commented Feb 5, 2023

When chromium source is fetched with extra params --no-history, there will be no tag info in the local .git repository, and ./scripts/pacthes.sh apply will fail because git push --set-upstream origin fix-for-patches fails, so use the commit hash instead.

@fathyb fathyb merged commit 8dca13c into fathyb:main Feb 6, 2023
@fathyb
Copy link
Owner

fathyb commented Feb 6, 2023

Thank you!

@licy183 licy183 deleted the fix-for-patches branch February 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants