Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package does not build for Go versions between 1.13 and 1.16 #183

Closed
pellared opened this issue Jan 23, 2023 · 3 comments · Fixed by #184
Closed

Package does not build for Go versions between 1.13 and 1.16 #183

pellared opened this issue Jan 23, 2023 · 3 comments · Fixed by #184

Comments

@pellared
Copy link
Contributor

It looks like the newest version does not support Go versions between 1.13 and 1.16.

# golang.org/x/sys/unix
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.3.0/unix/syscall.go:83:16: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.3.0/unix/syscall_linux.go:2[25](https://github.com/goyek/x/actions/runs/3987232497/jobs/6836778533#step:4:26)6:9: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.3.0/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.3.0/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
note: module requires Go 1.17

Possible fixes:

  • Change in go.mod to require Go 1.17

    color/go.mod

    Line 3 in 212f8c5

    go 1.13
  • Downgrade the dependencies so that it can work with Go 1.13

Personally, I think it is OK to bump to Go 1.17 as this is the oldest supported Go version.

Reference:

@pellared pellared changed the title https://github.com/fatih/color/releases/tag/v1.14.0 Package does not build for Go versions between 1.13 and 1.16. Jan 23, 2023
@pellared pellared changed the title Package does not build for Go versions between 1.13 and 1.16. Package does not build for Go versions between 1.13 and 1.16 Jan 23, 2023
@fatih
Copy link
Owner

fatih commented Jan 23, 2023

Downgrade the dependencies so that it can work with Go 1.13

That's not something I'm willing to do. The dependencies have bug fixes and it's safe for everyone to move forward. Best is to bump the Go version in the go.mod file.

@pellared
Copy link
Contributor Author

Downgrade the dependencies so that it can work with Go 1.13

That's not something I'm willing to do. The dependencies have bug fixes and it's safe for everyone to move forward. Best is to bump the Go version in the go.mod file.

I agree. I created a PR for you 😉

@fatih
Copy link
Owner

fatih commented Jan 23, 2023

I cut a new release https://github.com/fatih/color/releases/tag/v1.14.1. Thanks for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants