Broken code is not reported as broken by the linter

[dcu]

What did you do? (required: The issue will be closed when not provided)

1. enable golint-ci with auto checking when saving the file
2. Create a broken program like

package main

import "fmt"

func main() {
	broken
}

3. Save it

What did you expect to happen?

Get the possible lines where the code is broken, it used to be like that with gometalinter

What happened instead?

No errors were reported

Configuration (MUST fill this out):

let g:go_metalinter_command = "golangci-lint"
let g:go_metalinter_enabled = ['govet', 'golint', 'errcheck', 'gocyclo', 'deadcode', 'gosimple', 'staticcheck']
let g:go_metalinter_autosave_enabled = ['govet', 'golint', 'errcheck', 'gocyclo', 'deadcode', 'gosimple', 'staticcheck']
let g:go_metalinter_autosave = 1
let g:go_metalinter_deadline = "60s"

vim-go version:

master

vimrc you used to reproduce (use a minimal vimrc with other plugins disabled; do not link to a 2,000 line vimrc):

vimrc

Vim version (first three lines from :version):

8.1

Go version (go version):

1.13

Go environment

go env Output:

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="..."
GOENV="..."
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/tmp/"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/x1/2rp2t8l903d7dfdh9ldcpcs00000gn/T/go-build390465344=/tmp/go-build -gno-record-gcc-switches -fno-common"

[dcu]

I tracked down this issue to golangci/golangci-lint#276

[bhcleek]

You can workaround this by including typecheck in your enabled linters.

[dcu]

is it documented somewhere? It was really frustrating

[dcu]

I just tried it, enabling typecheck didn't work

[bhcleek]

we discovered that while looking into a similar issue: #2475 (comment)

[dcu]

looks like that workaround is no longer working @bhcleek in the terminal it's still 0 exit code (successful)

[dcu]

the commit from golangci-lint that breaks the workaround is 95ec0cf21ea4720ec9555c43176ab8b1d1b035f2 I just bisected it

[bhcleek]

Thanks for the heads up.

There's not much that vim-go can do about this; ultimately, it's a bug in golangci-lint.

[g00nix]

add this to your .vimrc:

nnoremap <F6> :w <CR> :GoTestCompile <CR> <CR>

When you want to save and check errors, hit F6. It will have the behavior you expect.