-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
realpath for testing #30
Comments
I’m still not sure why |
I've become profoundly uncomfortable not ensuring absolute paths in cases like this: Is that excessively paranoid? |
I believe it is. Let’s assume we omit the call to If someone were to actually do that, what problems would arise? Loading cli-harness.sh would fail and the script would abort with a helpful error message. If someone were to fix that error by fixing the path, the next I don’t think I’d do anything to prevent those errors, I’d much rather ensure that |
Oh, as a side note: I think I’d also symlink cli-harness.sh into the directories where it’s loaded in order to present a simpler environment to the test scripts. |
Done: faucet-pipeline/faucet-pipeline-js@9c80dbb (with similar commits in faucet-core, faucet-sass, faucet-static, faucet-images and nite-owl) |
@mkhl noticed that various plugins use corutils'
realpath
, which is not available by default on macOS and various Linux distributions (cf..travis.yml
)unfortunately, realpath adds another 46 packages (>1 MB) as dependencies, which seems silly:
thus we might want to offer a simplistic
realpath
implementation of our own - not quite sure how to do that safely thoughThe text was updated successfully, but these errors were encountered: