Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator not validating incomplete state pointset #193

Closed
noursaidi opened this issue Oct 26, 2021 · 1 comment
Closed

Validator not validating incomplete state pointset #193

noursaidi opened this issue Oct 26, 2021 · 1 comment
Assignees

Comments

@noursaidi
Copy link
Collaborator

Using the validator, the state_pointset does not raise an error if there are missing points. Conversely the validator correctly identifies missing points from the event_pointset

Example below, can be tested by adding points to the metadata for the pubber device

Processing device #1/12: AHU-9/state_pointset
Warning: Nashorn engine is planned to be removed from a future JDK release
Validation complete AHU-9/state_pointset
Processing device #1/12: AHU-9/state_system
Validation complete AHU-9/state_system
Processng device #2/12: AHU-9/event_pointset
java.lang.RuntimeException: Metadata validation failed: Missing points: missing_point
	at com.google.daq.mqtt.validator.ReportingDevice.validateMetadata(ReportingDevice.java:67)
	at com.google.daq.mqtt.validator.Validator.validateUpdate(Validator.java:381)
	at com.google.daq.mqtt.validator.Validator.validateMessage(Validator.java:286)
	at com.google.daq.mqtt.validator.Validator.lambda$messageValidator$0(Validator.java:233)
	at com.google.daq.mqtt.util.PubSubClient.processMessage(PubSubClient.java:112)
	at com.google.daq.mqtt.validator.Validator.messageLoop(Validator.java:261)
	at com.google.daq.mqtt.validator.Validator.validatePubSub(Validator.java:239)
	at com.google.daq.mqtt.validator.Validator.main(Validator.java:124)
Processing device #2/12: AHU-9/event_system

@grafnu
Copy link
Collaborator

grafnu commented Jun 7, 2022

Should be fixed now: #356

@grafnu grafnu closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants