Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when build #31

Closed
vuau opened this issue Apr 30, 2021 · 4 comments
Closed

error when build #31

vuau opened this issue Apr 30, 2021 · 4 comments
Labels
wontfix This will not be worked on

Comments

@vuau
Copy link

vuau commented Apr 30, 2021

> react-scripts build

Creating an optimized production build...
Failed to compile.

Can't find self.__WB_MANIFEST in your SW source.


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! fwitter@0.1.0 build: `react-scripts build`
npm ERR! Exit status 1

npm start working fine. I'm using node v12.22.1

@github-actions
Copy link

Internal ticket number is LABS-23

@n400
Copy link
Contributor

n400 commented Jul 5, 2021

@vuau I got this working by completely deleting service-worker.js and the sw-related code from index.js so index.js now reads:

import React from 'react'
import ReactDOM from 'react-dom'

import App from './app'
// import * as serviceWorker from './service-worker'

import './styling/index.scss'

ReactDOM.render(<App />, document.getElementById('root'))

And I've also successfully deployed to Vercel w/o any issues by doing this.

@vuau
Copy link
Author

vuau commented Jul 6, 2021

@n400 I'm gonna build a PWA so I need the service worker

@rts-rob
Copy link
Contributor

rts-rob commented Sep 17, 2021

Per our comment on #16 - we're closing this repo to feature development.

@rts-rob rts-rob closed this as completed Sep 17, 2021
@rts-rob rts-rob added the wontfix This will not be worked on label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants