Fixed order of arguments in If Statements #83
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Issue
The IF statements on a few files seem to have the arguments in the wrong order and I've only made the change in the setup/accounts.js file to confirm that I've understood it correctly before running with the changes to the rest of the files.
Proposed Fix
As I understand it, the If statement works as follows:
If(condition, true, false)
In that case, when we are deleting a collection or index, we're checking if it exists so:
Other Comments
The way it's currently stated in the files, nothing will be deleted since when the collection or index exists, it simply returns true.