Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update URL #104

Merged
merged 2 commits into from Dec 9, 2016
Merged

update URL #104

merged 2 commits into from Dec 9, 2016

Conversation

jchris
Copy link
Contributor

@jchris jchris commented Dec 7, 2016

I heard the endpoint was supposed to be db.fauna.com

@codecov-io
Copy link

codecov-io commented Dec 7, 2016

Current coverage is 95.57% (diff: 100%)

Merging #104 into master will not change coverage

@@             master       #104   diff @@
==========================================
  Files            10         10          
  Lines           633        633          
  Methods         157        157          
  Messages          0          0          
  Branches         76         76          
==========================================
  Hits            605        605          
  Misses           28         28          
  Partials          0          0          

Powered by Codecov. Last update 4024692...49d4af3

@erickpintor
Copy link
Contributor

Are both could and db pointing to the same cluster?

@sprsquish
Copy link
Contributor

Yes, cloud and db are aliases

@erickpintor
Copy link
Contributor

I would just add an entry on CHANGE.log. Besides that, it looks good.

Copy link
Contributor

@erickpintor erickpintor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchris jchris merged commit 995fb7f into master Dec 9, 2016
@jchris jchris deleted the service-url branch December 9, 2016 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants