Wrap faraday errors #177
Merged
Wrap faraday errors #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,6 +237,8 @@ def perform_request(action, path, query, data) | |||
| req.body = FaunaJson.to_json(data) unless data.nil? | |||
| req.url(path || '') | |||
| end | |||
| rescue Faraday::ConnectionFailed, Faraday::TimeoutError => e | |||
There was a problem hiding this comment.
You should also rescue any Faraday::Error and throw a UnexpectedError if status is not 503.
There was a problem hiding this comment.
The other two errors under Faraday::Error that we'd get are SSLError and ParsingError. I don't think we can expect a status code to be returned in either case, so I'll just raise UnavailableError for everything but ParsingError
ashfire908
force-pushed
the
wrap_faraday_errors
branch
from
b756387
to
8015370
Compare
ashfire908
force-pushed
the
wrap_faraday_errors
branch
from
8015370
to
9169dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps
Faraday::TimeoutErrorandFaraday::ConnectionErrorwithFauna::UnavailableError. Also throwsFauna::UnavailableErrorfor 503s even when we didn't get a valid JSON error back.