Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv-contrib-python-headless VS opencv-contrib-python #48

Closed
Johndirr opened this issue Mar 14, 2020 · 3 comments
Closed

opencv-contrib-python-headless VS opencv-contrib-python #48

Johndirr opened this issue Mar 14, 2020 · 3 comments

Comments

@Johndirr
Copy link

Would be nice if keras-ocr would use opencv-contrib-python instead of the headless version. Because the headless version does not have any GUI functionality. This way a user don't has to uninstall and install the desired opencv packages if he wants to have opencv gui functionalities.
What do you think?

@faustomorales
Copy link
Owner

faustomorales commented Mar 14, 2020

keras-ocr doesn't specify OpenCV as a dependency in setup.cfg / setup.py for the reason you suggest: I agree that users should be able to choose which flavor and version of the OpenCV package they wish to use. The reason that opencv-python-headless gets installed is because of the dependency on imgaug, for which I've already filed aleju/imgaug#473. It seems the compromise was to look for an existing OpenCV install first but that it doesn't seem to be working.

In other words, I'm not sure there's anything we can do in this package to remedy the matter. Let me know what you think.

@Johndirr
Copy link
Author

Since we can't do much about it maybe a note in the readme for the used opencv flawor is enough.

@faustomorales
Copy link
Owner

I've added comments describing this issue to 4f7d700. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants