Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Go 1.19 #193

Merged
merged 6 commits into from Aug 4, 2022
Merged

build: use Go 1.19 #193

merged 6 commits into from Aug 4, 2022

Conversation

favonia
Copy link
Owner

@favonia favonia commented Aug 3, 2022

Waiting for the new release of golangci-lint

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #193 (2c55fbf) into main (e089132) will decrease coverage by 0.59%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   83.31%   82.71%   -0.60%     
==========================================
  Files          27       27              
  Lines        1576     1585       +9     
==========================================
- Hits         1313     1311       -2     
- Misses        257      266       +9     
- Partials        6        8       +2     
Flag Coverage Δ
unittests 82.71% <84.61%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/api/domain.go 100.00% <ø> (ø)
internal/monitor/healthchecks.go 86.95% <82.85%> (-8.23%) ⬇️
internal/config/config.go 98.51% <100.00%> (ø)
internal/config/env.go 98.46% <100.00%> (-1.54%) ⬇️
internal/setter/setter.go 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@favonia favonia marked this pull request as draft August 3, 2022 18:19
@favonia favonia marked this pull request as ready for review August 4, 2022 13:46
@favonia favonia linked an issue Aug 4, 2022 that may be closed by this pull request
@favonia favonia merged commit 889a7c2 into main Aug 4, 2022
@favonia favonia deleted the go1.19 branch August 4, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new URL.JoinPath from Go 1.19
1 participant