Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): accept templates for PROXIED and TTL #214

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Conversation

favonia
Copy link
Owner

@favonia favonia commented Sep 4, 2022

No description provided.

@favonia favonia linked an issue Sep 4, 2022 that may be closed by this pull request
@favonia favonia force-pushed the template branch 2 times, most recently from 395148a to 62a9beb Compare September 5, 2022 00:17
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #214 (ee69edc) into main (a2b2e9b) will increase coverage by 0.66%.
The diff coverage is 99.46%.

❗ Current head ee69edc differs from pull request most recent head 76d0293. Consider uploading reports for the commit 76d0293 to get more accurate results

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   83.72%   84.38%   +0.66%     
==========================================
  Files          27       28       +1     
  Lines        1702     1755      +53     
==========================================
+ Hits         1425     1481      +56     
+ Misses        268      266       -2     
+ Partials        9        8       -1     
Flag Coverage Δ
unittests 84.38% <99.46%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/ddns.go 0.00% <0.00%> (ø)
internal/api/ttl.go 100.00% <100.00%> (ø)
internal/config/config.go 98.95% <100.00%> (+1.09%) ⬆️
internal/config/env.go 98.52% <100.00%> (+0.06%) ⬆️
internal/domain/domain.go 100.00% <100.00%> (ø)
internal/domain/fqdn.go 100.00% <100.00%> (ø)
internal/domain/template.go 100.00% <100.00%> (ø)
internal/domain/wildcard.go 100.00% <100.00%> (ø)
internal/setter/setter.go 100.00% <100.00%> (ø)
internal/updater/updater.go 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia force-pushed the template branch 7 times, most recently from c666eba to f8218e1 Compare September 5, 2022 01:28
@favonia favonia changed the title feat(config): PROXIED and TTL accept templates feat(config): accept templates for PROXIED and TTL Sep 5, 2022
@favonia favonia force-pushed the template branch 2 times, most recently from 72b8787 to ee69edc Compare September 5, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept Go templates for TTL and PROXIED
1 participant