New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better debug messages #45
Comments
I'd like to work on this issue, please. Thank you! |
Hi @TueNguyen2911 , I have assigned this task to you, code is in upload.js |
Thank you, I will look into it |
Hi @fawazahmed0, I took a look but most error messages addressing user's input are clear. Please unassign me from the task |
Hi @TueNguyen2911 , you can do anything, like for example refactor the code or any other thing to make code better, I will be happy to merge your PR. For example, you can replace Line 356 in d0f314d
Line 358 in d0f314d
with let uploadCompXPath = '//*[contains(text(),"Upload complete")]'
// Wait for upload to complete
await page.waitForXPath(uploadCompXPath , { timeout: 0 })
// Wait for upload to go away and processing to start
await page.waitForXPath(uploadCompXPath , { hidden: true, timeout: 0 }) |
Hi, thank you for your instructions, I took a look again and submitted a PR. |
Print better debug/error messages, so that user can easily understand the issue & solve it
The text was updated successfully, but these errors were encountered: