-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow exception #60
Comments
I think this is because of this:
This could easily be resolved by using |
Yes that's why, I'm fixing it right now to remove all MediaQuery usage to use layoutBuilder |
I've made the modifications to use layoutBuilder, but it doesn't work as in some case constraints return infinity as height and width. Instead I think we should use FractionallySizedBox to avoir doing the calculation ourselves |
I think this might be an issue with wrapping the root widget |
or maybe try the solution you mentioned. |
I have started like this but problem is that other Widget need the constraint (QuickReply, ContainerAvatar...) and I didn't want to wrap all of them with a layoutBuilder to gain in performance as only one is needed. I'll make some try some things.... |
Ok look like it works with layoutBuilders you can check the PR #59 here. |
Describe the bug
There is an overflow exception when the chat doesn't take the full width of the screen
To Reproduce
Use chat dash in master detail view and send a very long message
Expected behavior
Not having overflow
Screenshots
![Capture d’écran 2020-04-21 à 10 43 07](https://user-images.githubusercontent.com/2970449/79845136-e5c1e000-83bc-11ea-99ab-ac758b0cd061.png)
The text was updated successfully, but these errors were encountered: