Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Labels API: LabelsID?? #62

Closed
hoppfrosch opened this issue Mar 26, 2015 · 3 comments · Fixed by #63
Closed

Issue Labels API: LabelsID?? #62

hoppfrosch opened this issue Mar 26, 2015 · 3 comments · Fixed by #63

Comments

@hoppfrosch
Copy link

Within the implementation of Issue labels API $labelId is needed for most actions: http://search.cpan.org/~fayland/Net-GitHub/lib/Net/GitHub/V3/Issues.pm#Issue_Labels_API

But the github API does not use/provide any $labelId: https://developer.github.com/v3/issues/labels/ - the access is done via $labelName ....

=> Net::Github should also use $labelName instead if $labelId
@fayland
Copy link
Owner

fayland commented Mar 26, 2015

Hi, will take a look this weekend. patches welcome. ty

@hoppfrosch
Copy link
Author

This seems to be a documentation error only. Just tested your implementation by simply providing $labelName instead $labelId to your functions, and everything works fine.

I will provide a pull request for your documentation

@hoppfrosch hoppfrosch mentioned this issue Mar 26, 2015
Merged
@hoppfrosch
Copy link
Author

see Pull Request #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected the documentation of IssueLabels-API to $labelsName
2 participants
@fayland @hoppfrosch