Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to Project 2 offered up earlier than expected. #27

Closed
WillieMaddox opened this issue Jun 25, 2018 · 4 comments
Closed

Solution to Project 2 offered up earlier than expected. #27

WillieMaddox opened this issue Jun 25, 2018 · 4 comments

Comments

@WillieMaddox
Copy link
Contributor

In the following file, /python-deepdive/Part 2/Section 05 - Project 2/01 - Project - Description.ipynb, the line just before the code blocks begin reads,

Code from Previous Project

However, the code presented is actually the solution to the current project.

@fbaptiste
Copy link
Owner

Actually, I think this is OK. The code is the final step of the previous project. The goal in this project is to make the properties lazy - initially they are not. I think this is OK - but I'll clarify and specify that it was where we left off in Project 1.

@WillieMaddox
Copy link
Contributor Author

That's strange. That's not what I'm seeing from my end. I must have a different version or something. For example, the interior_angle property that I am seeing from the previous project (i.e. project 1) is,

@property
def interior_angle(self):
    self._interior_angle = (self._n - 2) * 180 / self._n

But, in the Project 2 01 - Project - Description.ipynb, I'm not showing the same code, but rather the solution with the lazy loading already applied,

@property
def interior_angle(self):
    if self._interior_angle is None:
        self._interior_angle = (self._n - 2) * 180 / self._n
    return self._interior_angle

@fbaptiste
Copy link
Owner

Oh, oh, oh... you're absolutely right - I was looking at the notebook for Goal 1 - not the project description.
Oops, not good to give away the answer so soon :-)
Thanks for that, I will make the updates.

@fbaptiste fbaptiste reopened this Jun 26, 2018
@fbaptiste
Copy link
Owner

OK, now it's actually fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants