The order of the input parameters of the AFB2D function

[wdanc]

Thanks for your great work.
I have a question about the order of the input parameters of the AFB2D function. In the transform2d.py line 70-71, the function take input parameters as
ll, high = lowlevel.AFB2D.apply(ll, self.h0_col, self.h1_col, self.h0_row, self.h1_row, mode)

pytorch_wavelets/pytorch_wavelets/dwt/transform2d.py

Line 70 in 8d2e3b4

ll, high = lowlevel.AFB2D.apply(

however, the function AFB2D forwardd in lowlevel.py line 336 take the order of inputs as h0_row, h1_row, h0_col, h1_col

pytorch_wavelets/pytorch_wavelets/dwt/lowlevel.py

Line 336 in 8d2e3b4

def forward(ctx, x, h0_row, h1_row, h0_col, h1_col, mode):

so, the order of the input "col col row row" seems to be inconsistent with the function's definition "row row col col". I wonder why it is entered in this way?

[fbcotter]

No reason, just bad practice by me! Happy to change it to be consistent

[wdanc]

No reason, just bad practice by me! Happy to change it to be consistent

Thanks for your reply. I have read relative functions, and I noticed you make sure the filters have the right dimension, therefore, the input order won't impact the result. And I'm happy that your answer helps me to confirm that.