Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charset utf-8 #26

Closed
95Key opened this issue Jul 9, 2020 · 9 comments
Closed

Charset utf-8 #26

95Key opened this issue Jul 9, 2020 · 9 comments

Comments

@95Key
Copy link

95Key commented Jul 9, 2020

First of all it’s awesome! Many thanks for your effort on data visualization! There is a small issue maybe, the html report lacks a meta tag showing the charset as “utf-8”; by adding it, the report can correctly show the MBCS characters and will catch eyes of more global analysts.
Thanks again! Hope this project goes better!

@davebulaval
Copy link

Same problem with French dataset no UTF-8 support.

@fbdesignpro
Copy link
Owner

@95Key @davebulaval thank you for submitting this! I was not able to respond for the past few days but we are testing #33 which should fix this, we will keep you posted!

@a246530
Copy link
Contributor

a246530 commented Jul 15, 2020

@95Key or @davebulaval , can you give me a copy of the dataset to check that this is fixed? i havent run into an issue with the encoding but added the meta tag per this request.
I downloaded a dataset with french in it and all chars displayed fine without the UTF-8 meta tag.

@95Key
Copy link
Author

95Key commented Jul 16, 2020

@a246530 Thank you for your prompt reply, I prepared a test file and hope to help you :)
stock_basic.csv.zip

@fbdesignpro
Copy link
Owner

@95Key thank you for the sample data, and @a246530 for checking it out; hopefully it fixes it!

@a246530
Copy link
Contributor

a246530 commented Jul 16, 2020

@fbdesignpro , i just tested this. It will show correct characters with the UTF-8 meta tag. It will not show them without it.

@fbdesignpro
Copy link
Owner

(Weird, I think the response just wrote disappeared? Writing it up again...) @a246530 it seems to be working but:
-Getting lots of warnings regarding missing glyphs during report generation
-Graphs will show a missing character symbol

This is due to CJK not being included in the fonts but I can work around that in an upcoming fix. For now I will probably just use your fix with text output. I just wanted to confirm this is the behavior you are seeing also. Thanks!

@a246530
Copy link
Contributor

a246530 commented Jul 16, 2020

Correct. I had missing glyphs errors as well.

@fbdesignpro
Copy link
Owner

Should be closed by 7c3a754.

STILL warnings + missing characters in graphs; It's on my to-do list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants