Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On v1.1.4,problem occurs with the node built with PROMPT_MAIN #378

Closed
dusanjp opened this issue Feb 19, 2022 · 4 comments · Fixed by #379
Closed

On v1.1.4,problem occurs with the node built with PROMPT_MAIN #378

dusanjp opened this issue Feb 19, 2022 · 4 comments · Fixed by #379

Comments

@dusanjp
Copy link

dusanjp commented Feb 19, 2022

When with bootstrap v1.1.4
renewCertificates does not work properly on nodes built using "privateKeySecurityMode: PROMPT_MAIN"
image

Also, if "privateKeySecurityMode: PROMPT_MAIN" is used and built new node with config / start is executed, an error will be issued and the process will end.
image

@dusanjp
Copy link
Author

dusanjp commented Feb 19, 2022

The custompreset used in this validation is:

`privateKeySecurityMode: PROMPT_MAIN
#privateKeySecurityMode: ENCRYPT
nodes:
-
#mainPrivateKey: 8B7B3769C2D1CD6B82E01AE6B5B0CC6723FB9ADEE5E70B98580C942FAA75D7A4
mainPublicKey: B473A112CCFFBB60E9A816DC86D97D4C41CED0D2067A1A105313A63E39E3BD5A

#main address = TAA6DP62XPOGLJ7EPOQZOSEBA3CH2QSOXMF4DVOZ`

Until v1.1.3, the above problems have not occurred.

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Feb 21, 2022

@fboucquez I investigated the issue.
The error happens in this line:
https://github.com/fboucquez/symbol-bootstrap/blob/dev/src/service/BootstrapAccountResolver.ts#L57

I was able to fix it by copy same method isValidPrivateKey into BootstrapAccountResolver and replace CommandUtils.isValidPrivateKey with BootstrapAccountResolver.isValidPrivateKey

Not sure what is cause but would be good to check other prompts with validation too.

@fboucquez
Copy link
Owner

fboucquez commented Feb 23, 2022

Thanks @dusanjp for reporting this issue.

@cryptoBeliever, thanks for the suggestion! It's one of those ugly circular dependencies that are hard to detect, related to how imports work, if the files import more than it should. Could you have a look at pr #379 ?

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Feb 26, 2022

Hello, @fboucquez I missed your comment. I've checked, and I'm able to:

  • renew certificates
  • send link transaction

with strategy PROMPT_MAIN 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants