New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old numba methods #86

Closed

2 tasks

RemiLehe opened this issue Jul 17, 2017 · 1 comment

Labels

cpu refactoring

Member

RemiLehe commented Jul 17, 2017 •

edited

Loading

These methods are superseded by the new threading methods of PR #80 .

Note: in order to be able to still use the old versions of numba (i.e. <0.34), we should do something like: in threading_utilities.py

if numba.version > 0.34: #The syntax maybe a bit different    
    threading_installed = True    
    prange = numba.prange 
else:
    threading_installed = False
    prange = range

Update: We still need to remove:

The old gathering functions
The old deposition functions (assuming they are not needed for the laser antenna)

Member Author

RemiLehe commented Jul 17, 2017

This depends on PR #80 being merged.

RemiLehe added cpu refactoring labels

RemiLehe closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment