Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help on discretization #566

Open
shahriar49 opened this issue Jan 18, 2022 · 0 comments
Open

Help on discretization #566

shahriar49 opened this issue Jan 18, 2022 · 0 comments

Comments

@shahriar49
Copy link

Hi,
I see in the project front page that the continuous data should be discretized. But:
1- When I give it continuous data I do not get any error.
2- If I want to discretize data, is it sufficient to just run for example sklearn's KBinsDiscretizer and give it the required number of bins with uniform strategy? This will not be the same as the strategy mentioned in the paper (i.e. considering mean+/-std and binning to -1, 0, and 1 accordingly) but I do not think that really matters. If the feature values are changed by a scale, why the feature selection mechanism should give us different results?
I hope to hear from you soon.

Best Regards
Shahriar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant